-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tensor layout #1237
Tensor layout #1237
Conversation
!build |
CI MESSAGE: [886996]: BUILD STARTED |
CI MESSAGE: [886996]: BUILD PASSED |
!build |
CI MESSAGE: [888428]: BUILD STARTED |
!build |
CI MESSAGE: [888574]: BUILD STARTED |
!build |
CI MESSAGE: [888584]: BUILD STARTED |
!build |
CI MESSAGE: [888629]: BUILD STARTED |
CI MESSAGE: [888629]: BUILD FAILED |
!build |
CI MESSAGE: [888649]: BUILD STARTED |
CI MESSAGE: [888649]: BUILD PASSED |
include/dali/core/tensor_layout.h
Outdated
return NumSpatialDims(tl) == 2; | ||
} | ||
DALI_HOST_DEV | ||
static int Is3D(const TensorLayout &tl) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do these return an int while the latter three return a bool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch.
6f87a6f
to
d5e05ca
Compare
!build |
CI MESSAGE: [891677]: BUILD STARTED |
CI MESSAGE: [891677]: BUILD FAILED |
CI MESSAGE: [891778]: BUILD STARTED |
CI MESSAGE: [891778]: BUILD FAILED |
CI MESSAGE: [903893]: BUILD PASSED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still a few of my comments, please respond to them
I'm wondering here, it might be my impression, but: |
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
…t analysis. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Added Doxygen comments. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Add tests for concatenation and extraction. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Add device-side tests for TensorLayout. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
* Use Alexandrescu's (?) trick to increase static capacity to 15. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
- add comments - add explicit tests for `skip` and `find` - add test for `GetFrameLayout` Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Add explicit case operator to std::string. Fix minor review issues. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
aa5c6dc
to
a0cd9f6
Compare
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
a0cd9f6
to
9325c71
Compare
!build |
CI MESSAGE: [905487]: BUILD STARTED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor thing left would be the indentatnions in switch...case
statement, please fix if you would be so kind, so it matches the GoogleStyle
CI MESSAGE: [905487]: BUILD PASSED |
* Add TensorLayout and accompanying functions for image and video layout analysis. * Add GetLayoutMapping function that finds fixed-size permutation of layouts. TODO * switch formatting * maybe: add variable-sized GetLayoutMapping (with result in SmallVector) Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com> Signed-off-by: Jianjun Liu <00liujj@163.com>
Why we need this PR?
What happened in this PR?
JIRA TASK: [DALI-525]